Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Invisible coverage #2202

Closed
alanshaw opened this issue Jun 26, 2019 · 2 comments
Closed

Invisible coverage #2202

alanshaw opened this issue Jun 26, 2019 · 2 comments
Assignees
@achingbrain
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/wontfix P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@alanshaw
Copy link
Member

We have test coverage we can't track.

Coverage for tests that run against a JS IPFS daemon (i.e. not an in-process node) is not tracked because the code for the daemon is not instrumented.

It means that when removing duplicate tests that exist both here and in interface-ipfs-core test coverage appears to lower even though this is not the case.
@alanshaw alanshaw added exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Jun 26, 2019
@mikeal
Copy link
Contributor

mikeal commented Jul 2, 2019

node-tap has a ton of code in it that instruments subprocesses so that even these kinds of things get test coverage. Maybe there is some code we can steal there.

@SgtPooki SgtPooki moved this to 🥞 Todo in js-ipfs deprecation May 17, 2023
@achingbrain
Copy link
Member

Closing as this issue is very stale. Helia tests in-process so this isn't a problem going forward.

@github-project-automation github-project-automation bot moved this from 🥞 Todo to ✅ Done in js-ipfs deprecation May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@achingbrain achingbrain

Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/wontfix P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
js-ipfs deprecation
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikeal @alanshaw @achingbrain