-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add support for ipns and recursive to ipfs resolve #2297
Conversation
1561255
to
fc76875
Compare
@@ -74,7 +74,6 @@ | |||
"bs58": "^4.0.1", | |||
"buffer-peek-stream": "^1.0.1", | |||
"byteman": "^1.3.5", | |||
"callbackify": "^1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
callbackify
is used here https://github.com/ipfs/js-ipfs/blob/813048ffb32a11cfefc51c2ec8634faaff2a924e/src/core/components/files-mfs.js so will need to be migrated to promise-nodeify
. Would be rad if you also migrated libp2p-kad-dht
😉🙏:
ipfs@0.37.0-rc.0 /Users/alan/Code/pl/ipfs/js-ipfs
├── callbackify@1.1.0
└─┬ libp2p-kad-dht@0.15.3
└── callbackify@1.1.0 deduped
BREAKING CHANGE: |
@hugomrdias 🙏 please can we have this one fixed up? |
57db3aa
to
41d2749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please unskip the resolve with IPNS interface tests?
js-ipfs/test/core/interface.spec.js
Lines 98 to 105 in 41d2749
{ | |
name: 'should resolve an IPNS DNS link', | |
reason: 'TODO: IPNS resolve not yet implemented https://github.com/ipfs/js-ipfs/issues/1918' | |
}, | |
{ | |
name: 'should resolve IPNS link recursively', | |
reason: 'TODO: IPNS resolve not yet implemented https://github.com/ipfs/js-ipfs/issues/1918' | |
}, |
blocked by #2416 |
Ok, DNS on ipfs.io has been fixed - @hugomrdias can you fix up the other test failures please? 🙏 |
This PR add IPNS support to resolve, makes the recursive option true by default and reworks the tests. Jsdocs were add to the resolve methods. Two interface-core config profile tests needed to be skipped because js-ipfs doesn't support them yet needs: ipfs-inactive/interface-js-ipfs-core#504
the api docs doesn't have this options so it's best to remove and simplify the logic
a9d5bc0
to
1e40992
Compare
ready |
This PR adds IPNS support to resolve, makes the recursive option true by default and reworks the tests.
Jsdocs were added to the resolve method.
Two interface-core config profile tests needed to be skipped because js-ipfs doesn't support them yet
ref:
#2000