Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Proposed fix for Issue #3330: files/ls should return string for type (not integer) #3345

Closed
wants to merge 1 commit into from

Conversation

gcohler
Copy link
Contributor

@gcohler gcohler commented Oct 24, 2020

I'm not expert enough to be sure this is the complete fix. But it appears to be about right.

Note that the changes may be breaking changes.

@welcome
Copy link

welcome bot commented Oct 24, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

achingbrain added a commit that referenced this pull request Oct 27, 2020
Supersedes #3345 #2939
Fixes #3330 #2948

BREAKING CHANGE: types returned by `ipfs.files.ls` are now strings, in line with the docs but different to previous behaviour

Co-authored-by: Geoffrey Cohler <g.cohler@computer.org>
@achingbrain
Copy link
Member

I've pulled this over the line in #3352 - thanks so much for opening this!

SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
Supersedes #3345 #2939
Fixes #3330 #2948

BREAKING CHANGE: types returned by `ipfs.files.ls` are now strings, in line with the docs but different to previous behaviour

Co-authored-by: Geoffrey Cohler <g.cohler@computer.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants