Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Export all types from "ipfs-core-types" root. #3713

Closed
ocknamo opened this issue Jun 11, 2021 · 1 comment
Closed

Export all types from "ipfs-core-types" root. #3713

ocknamo opened this issue Jun 11, 2021 · 1 comment
Assignees
Labels
effort/days Estimated to take multiple days, but less than a week kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/wontfix-migration-available need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up

Comments

@ocknamo
Copy link

ocknamo commented Jun 11, 2021

  • Version:

ipfs-core: 0.7.1

  • Platform:

Ubuntu 20.04.2 LTS
64-bit

  • Subsystem:

ipfs-core-types: 0.5.1

Severity:

Low

Description:

It would be useful if all types were exported from the root of "ipfs-core-types".

Pros

  • Application build do not fail when change the place of type definition file.
  • Easy to find types via support of editor. (I wrote this issue because I had a hard time finding the "ImportCandidateStream".)
  • Import statement will be reduced.

Cons

I have no idea.

example

// ipfs-core-types/src/index.d.ts
...

export * from './utils'
export * from './root'
export * from './bitswap'
export * from './block'
...

@ocknamo ocknamo added the need/triage Needs initial labeling and prioritization label Jun 11, 2021
@lidel lidel added effort/days Estimated to take multiple days, but less than a week kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up need/analysis Needs further analysis before proceeding and removed need/triage Needs initial labeling and prioritization labels Jul 16, 2021
@SgtPooki SgtPooki self-assigned this May 17, 2023
@SgtPooki
Copy link
Member

js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

Please feel to reopen with any comments by 2023-06-02. We will do a final pass on reopened issues afterward (see #4336).

This issue is most likely resolved in Helia, please try it out!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/days Estimated to take multiple days, but less than a week kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/wontfix-migration-available need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants