Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Implement --allow-big-block behavior from go-ipfs #3893

Closed
3 tasks
lidel opened this issue Sep 24, 2021 · 2 comments
Closed
3 tasks

Implement --allow-big-block behavior from go-ipfs #3893

lidel opened this issue Sep 24, 2021 · 2 comments
Assignees
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/maybe-in-helia P1 High: Likely tackled by core team if no one steps up topic/interop Interoperability

Comments

@lidel
Copy link
Member

lidel commented Sep 24, 2021

This is JS tracking issue to match --allow-big-block behavior from go-ipfs (ipfs/kubo#8414 and ipfs/kubo#8696)

TLDR: bigger blocks can't be exchanged over libp2p, so we want to make a loud error if that happens, but allow people to override it if they know what they are doing.

ipfs object patch, ipfs dag put and ipfs block put should detect when produced block is over the soft limit of 1MB, and return an error:

produced block is over 1MB: big blocks can't be exchanged with other peers. consider using dag-pb for automatic chunking of bigger files, or pass --allow-big-block to override.

TODO

@lidel lidel added exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up status/blocked Unable to be worked further until needs are met kind/maintenance Work required to avoid breaking changes or harm to project's status quo effort/hours Estimated to take one or several hours topic/interop Interoperability labels Sep 24, 2021
@lidel

This comment has been minimized.

@BigLep BigLep removed the status/blocked Unable to be worked further until needs are met label Jan 21, 2022
@lidel lidel changed the title Match ipfs object patch big block behavior from go-ipfs Implement --allow-big-block behavior from go-ipfs Jan 24, 2022
@lidel lidel added P1 High: Likely tackled by core team if no one steps up and removed P2 Medium: Good to have, but can wait until someone steps up labels Jan 24, 2022
@tinytb tinytb moved this to Weekly Candidates in IP JS (PL EngRes) v2 Oct 14, 2022
@SgtPooki SgtPooki moved this to 🥞 Todo in js-ipfs deprecation May 17, 2023
@whizzzkid whizzzkid moved this from 🥞 Todo to 🛑 Blocked in js-ipfs deprecation May 23, 2023
@whizzzkid
Copy link

js-ipfs is being deprecated in favor of Helia. You can follow the migration plan here #4336 and read the migration guide.

Please feel to reopen with any comments before 2023-06-05. We will do a final pass on reopened issues afterward (see #4336).

@github-project-automation github-project-automation bot moved this from 🛑 Blocked to ✅ Done in js-ipfs deprecation May 31, 2023
@github-project-automation github-project-automation bot moved this from Next to Done in IP JS (PL EngRes) v2 May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/maybe-in-helia P1 High: Likely tackled by core team if no one steps up topic/interop Interoperability
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants