This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: return nested value from dag.get #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're traversing thorough and object and the thing at the end of the path is a CID, load that thing and return it as the final value. Fixes #3957
oed
approved these changes
Dec 5, 2021
rvagg
approved these changes
Dec 6, 2021
This was referenced Jan 21, 2022
This was referenced Jan 21, 2022
This was referenced Jan 29, 2022
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
If we're traversing thorough and object and the thing at the end of the path is a CID, load that thing and return it as the final value, unless `localResolve` is true, in which case return the CID. Fixes #3957
This was referenced Aug 19, 2022
This was referenced Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're traversing thorough and object and the thing at the end of the path is a CID, load that thing and return it as the final value, unless
localResolveis true, in which case return the CID.Fixes #3957