This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: adapted to new ipfs-repo API #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on ipfs/js-ipfs-repo#140 |
|
@pgte please run |
|
@diasdavid tested and it runs locally, but first you need to link these to the respective branches: |
daviddias
suggested changes
Jul 3, 2017
src/core/components/config.js
Outdated
| @@ -15,23 +12,9 @@ module.exports = function config (self) { | |||
|
|
|||
| if (!key) { | |||
| return self._repo.config.get(callback) | |||
| } else { | |||
| return self._repo.config.get(key, callback) | |||
There was a problem hiding this comment.
Doesn't the IPFS repo figure this out by itself now?
src/core/components/config.js
Outdated
| @@ -42,13 +25,7 @@ module.exports = function config (self) { | |||
| return callback(new Error('Invalid value type')) | |||
| } | |||
There was a problem hiding this comment.
Isn't this validation happening inside the repo itself?
There was a problem hiding this comment.
It should. ipfs/js-ipfs-repo#140 supports this now (via ipfs/js-ipfs-repo@8e8055d).
Fixed.
daviddias
force-pushed
the
chore/repo-new-api
branch
from
1172e6a to
5de743a
Compare
|
@pgte tests fail because of: Wasn't this change supposed to be contemplated in the awesome endeavor? |
daviddias
approved these changes
Jul 4, 2017
daviddias
changed the title
|
@diasdavid I hadn't included this change in the awesome endeavour, it was in a separate PR which wasn't listed here, I didn't think you would merge it as part of this. |
dryajov
pushed a commit
that referenced
this pull request
Sep 1, 2017
* feat: adapted to new ipfs-repo API
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
BREAKING CHANGE. Previously swarm.peers would throw an uncaught error if any peer in the reponse could have its peerId or multiaddr validated. This PR catches errors that occur while validating the peer info. The returned array will contain an entry for every peer in the ipfs response. peer-info objects that couldn't be validated, now have an `error` property and a `rawPeerInfo` property. This at least means the count of peers in the response will be accurate, and there the info is available to the caller. This means that callers now have to deal with peer-info objects that may not have a `peer or `addr` property. Adds `nock` tests to exercice the code under different error conditions. Doing so uncovered a bug in our legacy go-ipfs <= 0.4.4 peer info parsing, which is also fixed. The code was trying to decapusalate the peerId from the multiaddr, but doing so trims the peerId rather than returning it. fixes ipfs#885 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipfs-repo dependents are: