-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add passphrase to init options #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardschneider I don't think we really need this changes for the daemons (js
and go
), but we do for the in-proc node.
if (initOpts.directory && initOpts.directory !== this.path) { | ||
this.path = initOpts.directory | ||
} | ||
|
||
run(this, ['init', '-b', keySize], { env: this.env }, (err, result) => { | ||
const args = ['init', '-b', initOpts.keysize || 2048] | ||
if (initOpts.pass) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardschneider this should already happen since args just get forwarded to the daemon.
@richardschneider I see we already addressed passing the |
@dryajov Yes |
@richardschneider |
Seems like my bad. So something like the below will add
|
@richardschneider - actually my bad. You're right, init takes an |
@dryajov Don't you have PR to fix the jenkins port sharing issue? If so can we merge it. |
@richardschneider yes, it's here - #196. Just need to make sure that we don't start non i.e. use something like this when starting non
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See #194