From 01708c7142224a202b462529be3d669a78442f30 Mon Sep 17 00:00:00 2001 From: achingbrain Date: Fri, 19 Apr 2024 12:30:05 +0100 Subject: [PATCH] chore: re-enable tests that use isOnline Now that isOnline will not throw when the node is offline, re-enable tests that use this API call. --- package.json | 2 +- test/controller.spec.ts | 3 +-- test/factory.spec.ts | 6 ++---- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index f6cce4d7..8b55c855 100644 --- a/package.json +++ b/package.json @@ -145,7 +145,7 @@ "@libp2p/logger": "^4.0.10", "execa": "^8.0.1", "joi": "^17.2.1", - "kubo-rpc-client": "^4.0.0", + "kubo-rpc-client": "^4.0.1", "merge-options": "^3.0.1", "nanoid": "^5.0.7", "p-defer": "^4.0.1", diff --git a/test/controller.spec.ts b/test/controller.spec.ts index 87b70c52..3df630f8 100644 --- a/test/controller.spec.ts +++ b/test/controller.spec.ts @@ -163,8 +163,7 @@ describe('Node API', function () { }) describe('stop', () => { - // https://github.com/ipfs/js-kubo-rpc-client/pull/222 - describe.skip('should stop the node', () => { + describe('should stop the node', () => { for (const opts of types) { it(`type: ${opts.type} remote: ${Boolean(opts.remote)}`, async () => { const node = await factory.spawn(opts) diff --git a/test/factory.spec.ts b/test/factory.spec.ts index dcf85f8b..a2948146 100644 --- a/test/factory.spec.ts +++ b/test/factory.spec.ts @@ -107,8 +107,7 @@ describe('`Factory spawn()` ', function () { } }) - // https://github.com/ipfs/js-kubo-rpc-client/pull/222 - describe.skip('`Factory.clean()` should stop all nodes', () => { + describe('`Factory.clean()` should stop all nodes', () => { let factory: Factory afterEach(async () => { @@ -127,8 +126,7 @@ describe('`Factory spawn()` ', function () { } }) - // https://github.com/ipfs/js-kubo-rpc-client/pull/222 - describe.skip('`Factory.clean()` should not error when controller already stopped', () => { + describe('`Factory.clean()` should not error when controller already stopped', () => { let factory: Factory afterEach(async () => {