Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmount (fix) fuse after unclean shutdown #1248

Open
3 tasks
jbenet opened this issue May 19, 2015 · 7 comments
Open
3 tasks

unmount (fix) fuse after unclean shutdown #1248

jbenet opened this issue May 19, 2015 · 7 comments
Labels
topic/fuse Topic fuse

Comments

@jbenet
Copy link
Member

jbenet commented May 19, 2015

Sometimes when ipfs shuts down it fails to unmount fuse. (may have been killed early, crashed, etc).

We need:

  • functionality to "really, really" unmount fuse.
  • should be called when ipfs starts up. (though, careful, there may be multiple ipfs daemons running!)
  • should be callable from something like ipfs mount clean [ <path> ] or ipfs mount --fix [ <path> ]

I think we need to think through this one for a bit.

cc @whyrusleeping @tv42

@jbenet
Copy link
Member Author

jbenet commented May 19, 2015

On linux, one of these works for me:

fusermount -u /ipfs
fusermount -u /ipns
sudo fusermount -u /ipfs
sudo fusermount -u /ipns
umount /ipfs
umount /ipns
umount -f /ipfs
umount -f /ipns
sudo umount -f /ipfs
sudo umount -f /ipns

On osx, one of these works for me:

umount /ipfs
umount /ipns
umount -f /ipfs
umount -f /ipns
sudo umount -f /ipfs
sudo umount -f /ipns
diskutil unmount /ipfs
diskutil unmount /ipns
diskutil unmount force /ipfs
diskutil unmount force /ipns
sudo diskutil unmount force /ipfs
sudo diskutil unmount force /ipns

@wking
Copy link
Contributor

wking commented May 19, 2015

On Mon, May 18, 2015 at 05:18:28PM -0700, Juan Batiz-Benet wrote:

(though, careful, there may be multiple ipfs daemons running!)

But only one of them is servicing the FUSE requests for a given
mount-point, right?

@wking
Copy link
Contributor

wking commented May 19, 2015

On Mon, May 18, 2015 at 05:22:43PM -0700, Juan Batiz-Benet wrote:

fusermount -u /ipfs
fusermount -u /ipns

If you have something currently working on the mounted filesystem
(e.g. ‘find /ipns’), you may need to use the ‘-z’ option too.

@tv42
Copy link
Contributor

tv42 commented May 19, 2015

Lazy unmounts leave the server process alive -> file locks are still held, can't run a new ipfs command, etc.

@jbenet jbenet mentioned this issue May 19, 2015
52 tasks
@whyrusleeping whyrusleeping mentioned this issue May 26, 2015
49 tasks
@whyrusleeping whyrusleeping mentioned this issue Jun 2, 2015
58 tasks
@whyrusleeping whyrusleeping mentioned this issue Jun 9, 2015
50 tasks
@jbenet jbenet mentioned this issue Jun 16, 2015
55 tasks
@whyrusleeping
Copy link
Member

👍 this needs some more UX work

@whyrusleeping whyrusleeping reopened this Jan 2, 2016
@jbenet jbenet closed this as completed Jan 2, 2016
@whyrusleeping whyrusleeping reopened this Jan 2, 2016
@daviddias daviddias added topic/fuse Topic fuse and removed topic/fuse Topic fuse labels Jan 2, 2016
@linas
Copy link

linas commented Oct 18, 2019

But issue #1092 is related, and its marked resolved: things do get unmounted...

@Stebalien
Copy link
Member

These are two separate issues. In that case, we weren't unmounting on Ctrl+C. In this case, the daemon is getting killed (no chance to unmount). We need to handle cleaning up the mount points the next time we start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/fuse Topic fuse
Projects
None yet
Development

No branches or pull requests

7 participants