Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mocknet race/double close #1788

Closed
whyrusleeping opened this issue Oct 3, 2015 · 2 comments
Closed

mocknet race/double close #1788

whyrusleeping opened this issue Oct 3, 2015 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws) panic topic/test failure Topic test failure

Comments

@whyrusleeping
Copy link
Member

mocknet panics if a connection is closed multiple times. I'm not sure this is the best course of action for it.

https://travis-ci.org/ipfs/go-ipfs/jobs/83475846
@whyrusleeping whyrusleeping added kind/bug A bug in existing code (including security flaws) topic/test failure Topic test failure panic labels Oct 3, 2015
@jbenet jbenet mentioned this issue Oct 4, 2015
Merged
@jbenet
Copy link
Member

jbenet commented Oct 4, 2015

closed in #1796

@jbenet jbenet closed this as completed Oct 4, 2015
@whyrusleeping
Copy link
Member Author

👍 wooo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) panic topic/test failure Topic test failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbenet @whyrusleeping