-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort out listing commands #3056
Labels
help wanted
Seeking public contribution on this issue
status/deferred
Conscious decision to pause or backlog
Comments
see my comment at: #3057 (comment) |
Example output of different commands:
{
"Objects": [{
"Hash": "<hash1>",
"Links": [{
"Name": "Books",
"Hash": "<hash2>",
"Size": 1838776295,
"Type": 1
}]
}]
}
{
"Arguments": {
"<hash1>": "<hash1>"
},
"Objects": {
"<hash1>": {
"Hash": "<hash1>",
"Size": 0,
"Type": "Directory",
"Links": [{
"Name": "Books",
"Hash": "<hash2>",
"Size": 1838776295,
"Type": "Directory"
}]
}
}
}
{
"Hash": "<hash1>",
"Links": [{
"Name": "Books",
"Hash": "<hash2>",
"Size": 1838776295
}]
}
{
"Entries": [{
"Name": "Books",
"Type": 0,
"Size": 0,
"Hash": ""
}]
} |
Several observation relating to the differences in commands
Some questions/suggestions
|
This was referenced Nov 29, 2018
Closing and we should track in the meta issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
help wanted
Seeking public contribution on this issue
status/deferred
Conscious decision to pause or backlog
Version/Platform/Processor information (from
ipfs version --all
): 16f8570 / 0.4.2Type (bug, feature, meta, test failure, question): feature
Area (api, commands, daemon, fuse, etc): api
Priority (from P0: functioning, to P4: operations on fire): P2
Currently, the
ipfs
command (and API) expose three different kinds of listing commands:ipfs ls
- listing links from an objectipfs object ls
- listing ... links from an objectipfs file ls
- listing directory contents for unixfs objectsipfs files ls
- listing directory contents for ...unixfs objectsThis obviously needs to be sorted out. Judging from the descriptions it seems there is an overlap between the
ls
andobject ls
but I'm not sure if they are. In the case offile ls
versusfiles ls
this is definitly not the case asfile ls
takes hases as arguments whereasfiles ls
only works within a unixfs root.In any case it seems worthwhile to unify these. So the question is: how to go about this? What functionality do we need and how might it be split up?
As per #3057 (comment), this ticket could be split up in a bunch more specific issues:
ipfs file ls
toipfs ls
Migrate full functionality ofipfs file ls
toipfs ls
#3081The text was updated successfully, but these errors were encountered: