Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-ipfs claims success dialing to a multiaddr without secio, however it fails at secio #3218

Closed
daviddias opened this issue Sep 13, 2016 · 2 comments
Closed

go-ipfs claims success dialing to a multiaddr without secio, however it fails at secio #3218

daviddias opened this issue Sep 13, 2016 · 2 comments
Labels
status/deferred Conscious decision to pause or backlog

Comments

@daviddias
Copy link
Member

Version/Platform/Processor information (from ipfs version --all):

go-ipfs version: 0.4.4-dev-3722e90
Repo version: 4
System version: amd64/darwin
Golang version: go1.7.1

Type (bug):
Area (commands, daemon):
Priority (from P0: operations on fire, to P4: functioning): P2

Description:

ipfs swarm connect /ip4/127.0.0.1/tcp/9090 will return 0, although it fails. This happens because it yields success after getting the TCP handshake performed.

Expected behaviour: fail because secio fails.

Ref:
This was referenced Sep 13, 2016
Closed
Closed
@ghost
Copy link

ghost commented Sep 13, 2016

Ideally it'd only succeed if the connection subsequently showed up in ipfs swarm peers

@whyrusleeping whyrusleeping added the status/deferred Conscious decision to pause or backlog label Sep 14, 2016
@Stebalien
Copy link
Member

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/deferred Conscious decision to pause or backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Stebalien @daviddias @whyrusleeping