Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all vendored code so far is appropriately licensed #337

Closed
jbenet opened this issue Nov 15, 2014 · 7 comments
Closed

Check all vendored code so far is appropriately licensed #337

jbenet opened this issue Nov 15, 2014 · 7 comments
Labels
exp/novice Someone with a little familiarity can pick up need/verification This issue needs verification topic/docs-ipfs Topic docs-ipfs

Comments

@jbenet
Copy link
Member

jbenet commented Nov 15, 2014

Make sure all libs vendored are appropriately licensed (MIT, BSD, APL2.0).

@jbenet jbenet added this to the OSS Hygiene milestone Nov 15, 2014
@jbenet jbenet added topic/docs-ipfs Topic docs-ipfs need/verification This issue needs verification difficulty: easy labels Mar 28, 2015
@jbenet jbenet removed this from the OSS Hygiene milestone Mar 29, 2015
@rht
Copy link
Contributor

rht commented Oct 16, 2015

Using https://www.npmjs.com/package/node-license-validator

$ node-license-validator -l .
Identified licenses: [Apache, BSD, ISC, MIT, MPL]

@rht
Copy link
Contributor

rht commented Oct 16, 2015

The package uses https://www.npmjs.com/package/spdx for its license algebra, but it isn't able to detect files without explicit license type, e.g. https://github.com/ipfs/go-ipfs/blob/master/Godeps/_workspace/src/github.com/kr/binarydist/License (MIT).

@jbenet
Copy link
Member Author

jbenet commented Oct 18, 2015

maybe we should add a test that fails if anything outside of the permissive licenses gets added.

@jbenet
Copy link
Member Author

jbenet commented Oct 18, 2015

though would not be good to have to depend on node.js installed for running ipfs tests.

@rht
Copy link
Contributor

rht commented Oct 23, 2015

There is an official go spdx library (one out of two, the other one being python, http://git.spdx.org/) that can be used.

In addition to the two, there are only node implementation (the one linked above) and haskell implementation.
cabal is in the process of adopting this (haskell/cabal#2547).

@whyrusleeping
Copy link
Member

our s3 datastore code relies on lgpl code at the moment.

@RichardLitt RichardLitt added exp/novice Someone with a little familiarity can pick up and removed difficulty: easy labels Feb 2, 2016
@whyrusleeping
Copy link
Member

We've gone through and removed the s3 lib, everything else is good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up need/verification This issue needs verification topic/docs-ipfs Topic docs-ipfs
Projects
None yet
Development

No branches or pull requests

4 participants