OSX Teamcity tests leave nc process running

[whyrusleeping]

The OSX teamcity tests will occasionally all start failling because some test run failed to clean up a netcat listener (on port 5005 I think). We should figure out where/why this is happening and fix it.

[whyrusleeping]

This appears to be in t0235:

14:     go-sleep 0.5s | nc -l 5005 > nc_out &

I'm not 100% sure, but i don't believe processes necessarily get killed if their input process dies.

[ghost]

Might need -o pipefail

[whyrusleeping]

@lgierth i don't think that would do it. The problem is that the nc process just isnt dying. setting pipefail would make just make it return non-zero when it exits if go-sleep returns a non-zero exit code.

[whyrusleeping]

cc @chriscool and @Kubuxu

[Kubuxu]

we can have test after it that always kills it.

but apart from that we should have teamcity run some sort of containers (docker, lxc, lxd, manual cgroups, whatever I don't care), and scrap the whole container after test is done.

[whyrusleeping]

@Kubuxu Yeah, we should be. But i'm not aware of any containerization stuff that works on OSX. I read that docker supports osx 'natively' but i'm not sure whether or not that means the OS inside the container will still be osx.

[chriscool]

I would suggest killing the process explicitly like this:

test_expect_success "can start nc server" '
	nc -l 5005 > nc_out &
'

test_expect_success "can make http request against nc server" '
	NC_PID=$! &&
	( ipfs cat /ipfs/Qmabcdef --api /ip4/127.0.0.1/tcp/5005 || true ) &&
	go-sleep 0.5s &&
	test_kill_repeat_10_sec $NC_PID
'

[Kubuxu]

This might be a solution: https://paolozaino.wordpress.com/2015/08/04/how-to-run-your-applications-in-a-mac-os-x-sandbox-to-enhance-security/

[Kubuxu]

This might be also general solution for those sorts of problems:

trap "exit" INT TERM
trap "kill 0" EXIT