Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add + Support an offset flag for ipfs cat #3578

Closed
daviddias opened this issue Jan 9, 2017 · 6 comments
Closed

Add + Support an offset flag for ipfs cat #3578

daviddias opened this issue Jan 9, 2017 · 6 comments
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@daviddias
Copy link
Member

What the title suggests :)
@daviddias daviddias added the kind/enhancement A net-new feature or improvement to an existing feature label Jan 9, 2017
@mib-kd743naq
Copy link
Contributor

Surely ipfs cat ... | tail -c +2000 is enough for this...?

@daviddias
Copy link
Member Author

We need to have support for it coming from the http-api too.

@ghost
Copy link

ghost commented Jan 9, 2017

Would Range headers satisfy this need on the http api? We get these for free with go's net/http. They're already used e.g. for skipping in a video/audio file through the gateway.

@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Mar 7, 2017
@whyrusleeping
Copy link
Member

@diasdavid how would we handle calling ipfs cat on multiple hashes? like ipfs cat QmdrSmgViWKCjRntzsoiFhzQ1Wsce2ig5nZErS7SvXr9Ng QmWJ7ot9xrhkSHwCqm9XAhnXe944nXYQQ3tCSmXfnxUWNj ?

@daviddias
Copy link
Member Author

Good question. What about simply treating the concatenation of both files as a single file for the offset?

@frrist frrist mentioned this issue Jan 2, 2018
Merged
@magik6k
Copy link
Member

magik6k commented Jan 2, 2018

Done in #4538

@magik6k magik6k closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daviddias @whyrusleeping @magik6k @mib-kd743naq