Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve defaults in Swarm.ConnMgr #8845

Closed
2 tasks
lidel opened this issue Apr 4, 2022 · 1 comment · Fixed by #8913
Closed
2 tasks

Improve defaults in Swarm.ConnMgr #8845

lidel opened this issue Apr 4, 2022 · 1 comment · Fixed by #8913
Assignees
@schomatis
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up topic/config Topic config
Milestone
kubo 0.15

Comments

@lidel
Copy link
Member

lidel commented Apr 4, 2022 •
edited
Loading

  • switch Swarm.ConnMgr config from hardcoded strings to optional types: 
    *OptionalString  `json:",omitempty"` // type
*OptionalInteger `json:",omitempty"` // low|high water
*OptionalDuration `json:",omitempty"` // graceperiod
    • this allows us to be backward-compatible, but remove default values from user config, enabling us to adjust implicit default over time
    • prior art – see how we use fields from Swarm.RelayService
  • (TBD) change the defaults to something lower (prior art: ipfs-desktop – but we can discuss new implicit defaults on the PR, and decide to not change them for now)
@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up topic/config Topic config labels Apr 4, 2022
@lidel lidel added this to the go-ipfs 0.14 milestone Apr 4, 2022
@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team Apr 4, 2022
@lidel
Copy link
Member Author

lidel commented Apr 6, 2022 •
edited
Loading

@schomatis i think you may add this to your queue (not urgent, but useful to fix)

@schomatis schomatis self-assigned this Apr 6, 2022
@schomatis schomatis moved this from 🥞 Todo to 🏃‍♀️ In Progress in IPFS Shipyard Team Apr 21, 2022
@schomatis schomatis mentioned this issue Apr 26, 2022
Merged
@schomatis schomatis moved this from 🏃‍♀️ In Progress to 🔎 In Review in IPFS Shipyard Team Apr 26, 2022
@BigLep BigLep modified the milestones: kubo 0.14, kubo 0.15 Jul 22, 2022
Repository owner moved this from 🔎 In Review to 🎉 Done in IPFS Shipyard Team Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schomatis schomatis

Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up topic/config Topic config
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
kubo 0.15
Development

Successfully merging a pull request may close this issue.

refactor(config): remove Swarm.ConnMgr defaults ipfs/kubo
3 participants
@BigLep @lidel @schomatis