Handle any supported IPLD codec for CAR imports #9198
Labels
kind/enhancement
A net-new feature or improvement to an existing feature
need/triage
Needs initial labeling and prioritization
Milestone
Checklist
Description
ipfs dag import
will fail on CAR imports containing blocks with codecs other than dag-cbor, dag-pb, and raw despite kubo having support for other codecs (e.g. dag-json, cbor, json, git, dag-jose, etc.).This seems to be due to the use of the
ipld.Decode
function from go-ipld-format which does not have the codecs registered in the default go-ipld-prime registry available.Uses include:
kubo/core/commands/dag/import.go
Line 93 in 9a87262
kubo/core/commands/dag/import.go
Line 184 in 9a87262
Probably replacing these with go-ipld-legacy's DecodeNode function and adding some testing would be sufficient.
Whether you count this as an issue or a bug likely depends on your perspective, however it's an unexpected result emergent from the work on #7976 although it doesn't seem like much if any functionality was lost.
The text was updated successfully, but these errors were encountered: