-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource Manager: Remove ResourceMgr.Limits
configuration from Kubo and use the default libp2p JSON file for it
#9603
Comments
ResourceMgr.Limits
configuration from Kubo and use the default libp2p JSON file for it
This comment was marked as resolved.
This comment was marked as resolved.
On the topic of |
+1 – no migration, most users won't have custom If someone set custom limits, we should error after update to new Kubo, asking them to remove Prior art ( Line 458 in ed4d6b7
|
Resource Manager config is really useful when you want to configure every aspect of your kubo node, but it is very complex for the average user.
We should remove
.Limits
field from our configuration, only allowing us to change MaxMemory and MaxFileDescriptors as configurable parameters for RM.If some experienced user wants to modify any RM low-level parameter, they can still do it by creating a
limits.json
file near by kubo config that will be read using default libp2p functions:https://github.com/libp2p/go-libp2p/blob/97607949208fc95bea759eeaa88db3ad2c86bf38/p2p/host/resource-manager/limit.go#L59
We also need to make a decision on how we handle legacy
Swarm.ResourceMgr.Limits
configuration.The text was updated successfully, but these errors were encountered: