Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'dht routing' design to accomodate router-specific features #9730

Open
3 tasks done
guseggert opened this issue Mar 16, 2023 · 1 comment
Open
3 tasks done
Labels
kind/feature A new feature P0 Critical: Tackled by core team ASAP

Comments

@guseggert
Copy link
Contributor

guseggert commented Mar 16, 2023

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

Kubo recently generalized its content routing to be able to use arbitrary content routers that satisfy the libp2p routing interface. This enables Kubo users to experiment with other content routers than the traditional Kademlia DHT. The core functionality works, but some peripheral functionality is broken as a result:

There might be other things that are broken too that we haven't found yet.

The code for constructing this also very complex and hard to understand, contributing to the bugginess.

Fundamentally this is because there are assumptions in certain commands and functionality that there's always a Kademlia DHT available, which is no longer true.

@guseggert guseggert added the kind/feature A new feature label Mar 16, 2023
@guseggert guseggert added the P0 Critical: Tackled by core team ASAP label Mar 16, 2023
@guillaumemichel
Copy link

Related to ipfs/go-ipfs-provider#49 and libp2p/go-libp2p#2175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A new feature P0 Critical: Tackled by core team ASAP
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants