t0030: replace some expect_failure with expect_success #926
Conversation
|
I'm not sure these are fixed on OSX. |
|
Yeah, maybe they are not fixed on OSX. I saw an OSX Jenkins test before, so I thought that the tests would tell us about OSX, but it looks like the OSX test has been removed from Jenkins. |
|
|
||
| test_expect_failure "'ipfs mount' fails when no mount dir (issue #341)" ' | ||
| test_expect_success "'ipfs mount' fails when no mount dir" ' |
There was a problem hiding this comment.
This one fails in osx still.
checking known breakage:
test_must_fail ipfs mount -f=not_ipfs -n=not_ipns >actual
test_must_fail: command succeeded: ipfs mount -f=not_ipfs -n=not_ipns
not ok 6 - 'ipfs mount' fails when no mount dir (issue #341) # TODO known breakage
|
@chriscool i've fixed the outstanding osx issue (#935) and enabled the osx test-- so presumably it wiill run next time you push. (so will need to rebase to grab the fix) |
Yeah, it was flakey unfortunately. I've replaced it with OSX on travis, which has been working well. |
chriscool
force-pushed
the
t0030_remove_expected_failures
branch
from
dcd254e to
8254724
Compare
|
I just rebased and force pushed to see if the OSX test pass now... |
|
@chriscool sorry about that, the repo location change does not mesh well with how Go likes doing imports. A fix went in for that at #996 -- still wondering what to do about the past history (bisecting to the past will not work with go's imports :( ). |
It looks like some tests that were expected failures are now always succeeding, so let's mark them as such. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
jbenet
force-pushed
the
t0030_remove_expected_failures
branch
from
8254724 to
e0c4638
Compare
|
just rebased |
|
Looks like it passed! |
t0030: replace some expect_failure with expect_success
It looks like some tests that were expected failures
are now always succeeding, so let's mark them as such.
License: MIT
Signed-off-by: Christian Couder chriscool@tuxfamily.org