First draft #1
First draft #1
Conversation
| .on('error', function (err) { cb(err) }) | ||
| .on('end', function () { def.resolve(true) }) | ||
| }, delay * 200) | ||
| delay++ |
There was a problem hiding this comment.
may want to say why it has to run this way?
There was a problem hiding this comment.
It seems there can be a race condition when you're setting two config variables at the same time. I will make an issue of this in my next sitting.
There was a problem hiding this comment.
Sounds like a good use case for waterfall promises.
There was a problem hiding this comment.
|
|
|
nice screenshot |
|
@krl this is great |
| var rimraf = require('rimraf') | ||
|
|
||
| // happy lint | ||
| // var it, before, after |
There was a problem hiding this comment.
Does this actually work to allow standard to not complain about undefined? I usually see something like:
/* global beforeEach, describe, it */
|
@travisperson thank you for pointing me at waterfall promises, will def be using this from now on! Pushed new version with this method |
krl
force-pushed
the
first-draft
branch
2 times, most recently
from
44e3ac7
to
2e3b595
Compare
|
👍 Thanks for doing this! |
|
What is the relationship between https://www.npmjs.com/package/ipfs-api and https://www.npmjs.com/package/go-ipfs? Will ipfs-api provide access to the webapp that the go implementation has? |
|
@bcomnes ipfs-api is a js lib for consuming/using the ipfs api provided by go-ipfs. (it's an http server run by go-ipfs, and other implementations should probably support it (match the api) too) |
|
This LGTM |
krl
force-pushed
the
first-draft
branch
3 times, most recently
from
5c84b62
to
ba6a9e2
Compare
krl
force-pushed
the
first-draft
branch
2 times, most recently
from
0149b44
to
0eca5d3
Compare
krl
force-pushed
the
first-draft
branch
3 times, most recently
from
1452a05
to
0016bb1
Compare
krl
force-pushed
the
first-draft
branch
2 times, most recently
from
c545bb1
to
f9d2f29
Compare
|
@krl shall we merge this? |
|
Baller! Nice work @krl Just had a chance to play around with it. Seems to work as expected |
I would like it to actually do init automatically as well, then i'll update the readme.