Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Delegated Routing V1 Endpoints #63

Closed
Tracked by #24
hacdias opened this issue May 6, 2024 · 1 comment
Closed
Tracked by #24

Default Delegated Routing V1 Endpoints #63

hacdias opened this issue May 6, 2024 · 1 comment
Labels
kind/discussion Topical discussion; usually not changes to codebase

Comments

@hacdias
Copy link
Member

hacdias commented May 6, 2024

This is an issue to track potentially adding more routing endpoint default to someguy. At the moment, we ask the DHT and cid.contact. The question is: should we also ask delegated-ipfs.dev? Only that one? Or both?

Quoting @lidel from #50 (comment):

I think we need to discuss (here or in #24 (comment)) a policy for cases like this one, because whatever we decide here, the same PR could/should be applied to Kubo and Rainbow.

On one hand, makes sense to leverage delegated-ipfs.dev more, allows people to benefit from public caching utility that supports peer and ipns routing and Amino DHT proxy (the https://cid.contact/routing/v1 endpoint does not provide any of these things).

Do we

  • (A) keep both here and accept duplicated IPNI (cid.contact) results for improved resiliency,
  • (B) or is it better to remove cid.contact from being hardcoded in our software (since we are not ones operating that IPNI instance) and hide it behind our caching proxy, which already talks to cid.contact and caches results?

cc @aschmahmann

And

Question: how do we avoid cycles in waterworks-infra when someguy with this PR is deployed to delegated-ipfs.dev?
I think we want to avoid a situation where someguy is sending query to itself. Is the plan to set SOMEGUY_PROVIDER_ENDPOINTS="https://cid.contact" SOMEGUY_PEER_ENDPOINTS="" SOMEGUY_IPNS_ENDPOINTS="" in waterworks-infra?

That should be enough, but if we ever need a more generic solution, we could look into ipfs/specs#426.

@hacdias hacdias changed the title defaults: in addition to DHT, should we ask both delegated-ipfs.dev and cid.contact, or only delegated-ipfs.dev? Default Delegated Routing V1 Endpoints May 6, 2024
@2color
Copy link
Member

2color commented Nov 14, 2024

@lidel Can we close this issue?

Would adding delegated-ipfs.dev to the defaults result in an amplification attack and duplicate results?

@gammazero gammazero added the kind/discussion Topical discussion; usually not changes to codebase label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Topical discussion; usually not changes to codebase
Projects
None yet
Development

No branches or pull requests

3 participants