php doesn't recognize environment variables

[yevgenko]

I might be missing, but php doesn't see environment variables with this buildpack, e.g.:

getenv("CLEARDB_DATABASE_URL");

or

getenv("BUILDPACK_URL");

doesn't return anything.

I also found that original buildpack puts environment variables into httpd.conf in boot.sh script, see: https://github.com/heroku/heroku-buildpack-php/blob/master/bin/compile#L50

[iphoting]

You need to modify php-fpm.conf to specifically defined allowed env vars.
https://github.com/iphoting/heroku-buildpack-php-tyler/blob/master/conf/php-fpm.conf#L463

Just copy the php-fpm.conf from this buildpack and drop it with your changes in your app's conf/ folder; the copy from your app's conf/ folder will override that of from this buildpack.

Indeed, the way env is done in the original buildpack boot.sh is quite interesting. I'll try to adapt the idea when I'm free over the coming weeks. In anyway, I don't mind a pull request either.

[iphoting]

I've added this feature to commit 997e021.

Please help me test this in the develop branch like so:

heroku config:add BUILDPACK_URL=git://github.com/iphoting/heroku-buildpack-php-tyler.git#develop

Let me know if it works.

[yevgenko]

Thank you Ronald, it works :)

Especially if I start a fresh app, e.g.:

heroku create -s cedar -b git://github.com/iphoting/heroku-buildpack-php-tyler.git#develop

Changing BUILDPACK_URL on existent app doesn't seems to reflect instantly, only after the next push, but I assume it is something heroku specific.

[iphoting]

Yes, it's heroku specific as the changes to the buildpack will only be exhibited in the app after the "compilation process".

I will merge it into master soon, if nothing breaks.

Shall close this issue.