Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of budgets in preloading #507

Open
hannahhoward opened this issue Apr 3, 2023 · 1 comment
Open

Better handling of budgets in preloading #507

hannahhoward opened this issue Apr 3, 2023 · 1 comment
Assignees
Labels
P2 Medium: Good to have, but can wait until someone steps up

Comments

@hannahhoward
Copy link
Collaborator

Goals

Budgets and preloading are an inherently challenging area, but we can probably do better than the current approach.

Right now, for a link budget of N, we can preload up to N^2 / 2 links I think (essentially, I'm imagining a depth N graph, with N links at each level. We would essentially preload (n-1)+(n-2)+(n-3)... as we walked down the left edge of the graph).

I wonder if it would make sense to treat the budget as simply seperate for preloading. A budget is given to the preloader with the same initial target, and when the budget is expended, we shift to just doing no preloading.

This would wait preloading towards the top of the graph, but perhaps that's what's most important?

@rvagg
Copy link
Member

rvagg commented Apr 4, 2023

I think we should experiment in the preloader logic in Lassie and then bring that back here when we extract out the core of it. Keep track and if we max out the preloader budget then new Preload() calls are just noops.

@rvagg rvagg self-assigned this Apr 4, 2023
@rvagg rvagg added the P2 Medium: Good to have, but can wait until someone steps up label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium: Good to have, but can wait until someone steps up
Projects
Status: 🥞 Todo
Development

No branches or pull requests

2 participants