Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose contentType #142

Merged
merged 1 commit into from
Jul 19, 2023
Merged

feat: expose contentType #142

merged 1 commit into from
Jul 19, 2023

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Jul 19, 2023

We found ourselves using a wrong application/car content type before we discovered it was a mistake storacha/ucanto#269. Change here just exports official
contentType for the CAR format so that users of the library can simply reference it and hopefully avoid mistakes we made.

Expose official `contentType` header  for the CAR format
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gozala Gozala merged commit 65e2758 into master Jul 19, 2023
@Gozala Gozala deleted the feat/content-type branch July 19, 2023 20:11
github-actions bot pushed a commit that referenced this pull request Jul 19, 2023
## [5.2.0](v5.1.1...v5.2.0) (2023-07-19)

### Features

* expose contentType ([#142](#142)) ([65e2758](65e2758))
@github-actions
Copy link

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants