This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
fix: replace node buffers with uint8arrays #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module now accepts Uint8Arrays as well as node Buffers and returns Uint8Arrays. Internally it converts non-Buffers into Buffers because the ethereum libs require that. BREAKING CHANGES: - `util.serialize` returns a `Uint8Array` - `util.cid` returns `CID`s with a breaking API change - see multiformats/js-cid#117 for changes
achingbrain
changed the title
achingbrain
force-pushed
the
fix/replace-buffers-with-uint8arrays
branch
from
b2173cf
to
759e76d
Compare
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 84.79% 84.90% +0.11%
==========================================
Files 8 8
Lines 263 265 +2
==========================================
+ Hits 223 225 +2
Misses 40 40
Continue to review full report at Codecov.
|
7 tasks
vmx
approved these changes
Aug 4, 2020
64 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module now accepts Uint8Arrays as well as node Buffers and
returns Uint8Arrays. Internally it converts non-Buffers into Buffers
because the ethereum libs require that.
BREAKING CHANGES:
util.cidreturnsCIDs with a breaking API change - see fix: replace node buffers with uint8arrays multiformats/js-cid#117 for changes