Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to native web streams #56

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Conversation

talentlessguy
Copy link
Contributor

@talentlessguy talentlessguy commented Jan 13, 2024

resolves #55

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good, just a few tweaks needed! Thanks for submitting.

I think the main thing is that there's no runtime code changes here so there's no need to release a new major version and as far as I can tell, no need to specify v20 as we've not changed anything.

Note: you need to change the node versions in github actions - I suggest we use 18 and 20 now those are LTS.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@alanshaw alanshaw merged commit 23dd7e1 into ipld:main Jan 16, 2024
4 checks passed
@talentlessguy talentlessguy deleted the remove-web-std branch January 16, 2024 11:45
@talentlessguy
Copy link
Contributor Author

thx for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop depending on @web-std/* modules
2 participants