Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assign publishers when pool assignments are unknown #1118

Closed
gammazero opened this issue Dec 10, 2022 · 0 comments · Fixed by #1116 or #1117
Closed

Do not assign publishers when pool assignments are unknown #1118

gammazero opened this issue Dec 10, 2022 · 0 comments · Fixed by #1116 or #1117

Comments

@gammazero
Copy link
Collaborator

If an indexer is offline when the assigner service starts, the assigner cannot read the existing assignments or preferences from that indexer. The assigner will not know what publishers are assigned to that indexer, resulting in assigning those publishers to other indexers as announcements from them arrive. That can result in over-assigning publishers to the indexer pool.

This is further complicated by the assigner not reading preferred assignments (peers that an indexer has previously stored content for but are not assigned to it) when the indexer comes back online. When another indexer has those same preferences, all the assignments are given to the indexer whose preferences are know, even though both indexers are now online.

This is particularly problematic when indexers are newly configured to use an assigner, because most of the assignments happen in a short amount of time as new announce messages arrive. This is what happened on the prod indexers.

To fix this, two things are needed:

  • Reset the assignments on the indexers
  • Update the assigner to not assign publishers when pool assignments are unknown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant