Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.27.0 broke the %edit magic #1170

Closed
ccordoba12 opened this issue Nov 23, 2023 · 4 comments · Fixed by #1171
Closed

6.27.0 broke the %edit magic #1170

ccordoba12 opened this issue Nov 23, 2023 · 4 comments · Fixed by #1171
Labels

Comments

@ccordoba12
Copy link
Member

ccordoba12 commented Nov 23, 2023

  • We have a test for that magic in Spyder and it started to fail with 6.27.0.
  • I checked locally and can confirm that that's the case: the magic works well in 6.26.0 but fails in 6.27.0
  • My guess is that the problem was introduced by the changes done in PR Extend argument handling of do_execute with cell metadata #1169.

@blink1073, could you take a look at this one? I'd love to help but unfortunately I don't have time to do it right now.

@blink1073
Copy link
Contributor

I've yanked the 6.27.0 release, I'll see about adding tests for some magics before releasing again.

@blink1073 blink1073 added the bug label Nov 24, 2023
@blink1073
Copy link
Contributor

Can you point me to your existing tests?

@ccordoba12
Copy link
Member Author

It's this one:

https://github.com/spyder-ide/spyder/blob/06a148be300ca830fa74b69c20105cd8f72a3c72/spyder/app/tests/test_mainwindow.py#L84

What we do is testing that running %edit foo.py in the console opens foo.py in our editor. I don't know how to test that only in the kernel.

@blink1073
Copy link
Contributor

This was actually the offending change, from my linting PR. Path vs str, tricky...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants