Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run all can reorder executions on Windows #356

Closed
stonebig opened this issue Oct 4, 2018 · 4 comments · Fixed by #362
Closed

run all can reorder executions on Windows #356

stonebig opened this issue Oct 4, 2018 · 4 comments · Fixed by #362
Milestone
5.1

Comments

@stonebig
Copy link
Contributor

stonebig commented Oct 4, 2018

jupyter/notebook#4052
@stonebig
Copy link
Contributor Author

stonebig commented Oct 6, 2018

going back to ipykernel-4.9.0 for now, until further direction

@minrk minrk changed the title shall we downgrade ipykernel to previous version to get back reproducible notebooks run all can skip cells Oct 8, 2018
@minrk
Copy link
Member

minrk commented Oct 8, 2018

This is a bug in 5.0, we will fix it and release 5.0.1. For those affected, pinning ipykernel<5 will avoid the problem. FWIW, I cannot reproduce it with the given notebooks, so it does seem to be isolated to some environment that I have not yet identified.

@minrk
Copy link
Member

minrk commented Oct 8, 2018

From reports, this appears to be a bug confined to Windows.

@dhirschfeld dhirschfeld mentioned this issue Oct 8, 2018
Closed
@minrk minrk changed the title run all can skip cells run all can reorder executions on Windows Oct 8, 2018
@minrk minrk mentioned this issue Oct 8, 2018
Merged
@minrk minrk added this to the 5.1 milestone Oct 8, 2018
@minrk minrk mentioned this issue Oct 8, 2018
Merged
@minrk minrk closed this as completed in #362 Oct 9, 2018
@minrk
Copy link
Member

minrk commented Oct 9, 2018

ipykernel 5.1 is out with the fix

@jasongrout jasongrout mentioned this issue Oct 10, 2018
Closed
@stonebig stonebig mentioned this issue Oct 11, 2018
Closed
@minrk minrk mentioned this issue Nov 12, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1
Development

Successfully merging a pull request may close this issue.

use integer counter instead of loop.time() to preserve message ordering minrk/ipykernel
2 participants
@minrk @stonebig