From 613947370145db89db336556372a6d9d19e36caa Mon Sep 17 00:00:00 2001
From: Albert Zeyer <albzey@gmail.com>
Date: Fri, 1 Feb 2019 14:54:53 +0100
Subject: [PATCH] do not catch system exceptions like KeyboardInterrupt

You never should use `except:` in general. In this case, you probably do not want to catch exceptions like `KeyboardInterrupt`.
---
 traitlets/traitlets.py | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/traitlets/traitlets.py b/traitlets/traitlets.py
index be2a8f95..fb55819b 100644
--- a/traitlets/traitlets.py
+++ b/traitlets/traitlets.py
@@ -50,7 +50,7 @@
 try:
     from types import ClassType, InstanceType
     ClassTypes = (ClassType, type)
-except:
+except Exception:
     ClassTypes = (type,)
 from warnings import warn, warn_explicit
 
@@ -564,7 +564,7 @@ def set(self, obj, value):
         obj._trait_values[self.name] = new_value
         try:
             silent = bool(old_value == new_value)
-        except:
+        except Exception:
             # if there is an error in comparing, default to notify
             silent = False
         if silent is not True:
@@ -1725,7 +1725,7 @@ def validate(self, obj, value):
         try:
             if issubclass(value, self.klass):
                 return value
-        except:
+        except Exception:
             pass
 
         self.error(obj, value)
@@ -2021,7 +2021,7 @@ class CInt(Int):
     def validate(self, obj, value):
         try:
             value = int(value)
-        except:
+        except Exception:
             self.error(obj, value)
         return _validate_bounds(self, obj, value)
 
@@ -2058,7 +2058,7 @@ class CLong(Long):
         def validate(self, obj, value):
             try:
                 value = long(value)
-            except:
+            except Exception:
                 self.error(obj, value)
             return _validate_bounds(self, obj, value)
 
@@ -2127,7 +2127,7 @@ class CFloat(Float):
     def validate(self, obj, value):
         try:
             value = float(value)
-        except:
+        except Exception:
             self.error(obj, value)
         return _validate_bounds(self, obj, value)
 
@@ -2152,7 +2152,7 @@ class CComplex(Complex):
     def validate (self, obj, value):
         try:
             return complex(value)
-        except:
+        except Exception:
             self.error(obj, value)
 
 # We should always be explicit about whether we're using bytes or unicode, both
@@ -2176,7 +2176,7 @@ class CBytes(Bytes):
     def validate(self, obj, value):
         try:
             return bytes(value)
-        except:
+        except Exception:
             self.error(obj, value)
 
 
@@ -2204,7 +2204,7 @@ class CUnicode(Unicode):
     def validate(self, obj, value):
         try:
             return six.text_type(value)
-        except:
+        except Exception:
             self.error(obj, value)
 
 
@@ -2263,7 +2263,7 @@ class CBool(Bool):
     def validate(self, obj, value):
         try:
             return bool(value)
-        except:
+        except Exception:
             self.error(obj, value)
 
 
@@ -2887,7 +2887,7 @@ class CRegExp(TraitType):
     def validate(self, obj, value):
         try:
             return re.compile(value)
-        except:
+        except Exception:
             self.error(obj, value)