From e35d00338a3ac9f8943a5f7050c632939ebe14cb Mon Sep 17 00:00:00 2001 From: Scott Todd Date: Mon, 7 Mar 2022 16:37:52 -0800 Subject: [PATCH] Include most Vulkan tests in ASAN build. --- build_tools/cmake/test.sh | 3 +-- .../cmake/linux/x86-swiftshader-asan/build.sh | 12 +++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/build_tools/cmake/test.sh b/build_tools/cmake/test.sh index bb0c5c54d016..50d4640be4ed 100755 --- a/build_tools/cmake/test.sh +++ b/build_tools/cmake/test.sh @@ -18,8 +18,7 @@ fi # Respect the user setting, but default to as many jobs as we have cores. export CTEST_PARALLEL_LEVEL=${CTEST_PARALLEL_LEVEL:-$(nproc)} -# Respect the user setting, but default to turning off the vulkan tests -# and turning on the llvmaot ones. +# Respect the user setting, but default to turning on vulkan and llvmaot. export IREE_VULKAN_DISABLE=${IREE_VULKAN_DISABLE:-0} export IREE_LLVMAOT_DISABLE=${IREE_LLVMAOT_DISABLE:-0} # CUDA is off by default. diff --git a/build_tools/kokoro/gcp_ubuntu/cmake/linux/x86-swiftshader-asan/build.sh b/build_tools/kokoro/gcp_ubuntu/cmake/linux/x86-swiftshader-asan/build.sh index 0076da613c1f..1e0826cdd070 100755 --- a/build_tools/kokoro/gcp_ubuntu/cmake/linux/x86-swiftshader-asan/build.sh +++ b/build_tools/kokoro/gcp_ubuntu/cmake/linux/x86-swiftshader-asan/build.sh @@ -52,10 +52,8 @@ echo "------------------" # Respect the user setting, but default to as many jobs as we have cores. export CTEST_PARALLEL_LEVEL=${CTEST_PARALLEL_LEVEL:-$(nproc)} -# Respect the user setting, but default to turning off the vulkan tests -# and turning on the llvmaot ones. -# TODO(#5716): Fix and enable Vulkan tests. -export IREE_VULKAN_DISABLE=${IREE_VULKAN_DISABLE:-1} +# Respect the user setting, but default to turning on vulkan and llvmaot. +export IREE_VULKAN_DISABLE=${IREE_VULKAN_DISABLE:-0} export IREE_LLVMAOT_DISABLE=${IREE_LLVMAOT_DISABLE:-0} # CUDA is off by default. export IREE_CUDA_DISABLE=${IREE_CUDA_DISABLE:-1} @@ -105,7 +103,11 @@ label_exclude_regex="($(IFS="|" ; echo "${label_exclude_args[*]?}"))" # These tests currently have asan failures # TODO(#5715): Fix these declare -a excluded_tests=( + # Mysterious "LeakSanitizer has encountered a fatal error." crashes "iree/samples/simple_embedding/simple_embedding_vulkan_test" + "iree/tools/test/iree-benchmark-module.mlir.test" + "iree/tools/test/iree-run-module.mlir.test" + "iree/tools/test/multiple_exported_functions.mlir.test" ) # Prefix with `^` anchor @@ -120,5 +122,5 @@ cd ${CMAKE_BUILD_DIR?} echo "Testing with ctest" ctest --timeout 900 --output-on-failure \ - --label-exclude "^driver=cuda$|^driver=vulkan$" \ + --label-exclude "${label_exclude_regex}" \ --exclude-regex "${excluded_tests_regex?}"