Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: require callback per node.js DEP0013 #167

Open
coreyfarrell opened this issue Aug 5, 2019 · 0 comments · May be fixed by #173
Open

Feature: require callback per node.js DEP0013 #167

coreyfarrell opened this issue Aug 5, 2019 · 0 comments · May be fixed by #173

Comments

@coreyfarrell
Copy link
Collaborator

DEP0013: fs asynchronous function without callback has been a runtime deprecation since node.js 7, an error since node.js 10. I do not think graceful-fs needs to wait for node.js 10 to be the minimum version before it starts imposing this requirement.

Obviously this would be a semver-major change. Are you open to making this change? Do you think callback based functions which are not currently patched should be patched to require a callback (effectively backport the node.js 10 error)?

@coreyfarrell coreyfarrell linked a pull request Aug 11, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant