Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK should point to rust_rsi instead of rsi_el0 #382

Open
jinbpark opened this issue Oct 22, 2024 · 4 comments
Open

SDK should point to rust_rsi instead of rsi_el0 #382

jinbpark opened this issue Oct 22, 2024 · 4 comments

Comments

@jinbpark
Copy link
Collaborator

It seems that rsi_el0 is deprecated and rust-rsi in remote-attestation repo has replaced rsi-el0.
rsictl, a tool to test attest and verify, points to rust-rsi and thus works well, while islet-cli pointing to rsi-el0 doesn't work out (error log: Failed to get attestation report).

This is because,
sdk is using rsi_el0::attestation_token(&challenge) which is incompatible with the current rsi.ko.
SDK should be updated like rust_rsi::attestation_token(&challenge) as in rsictl.

@bitboom
Copy link
Collaborator

bitboom commented Oct 22, 2024

Both the islet-sdk and islet-cli code are still using the old rsi_el0 as you said. Additionally, the islet-cli duplicates functionality with rsictl. (This divergence occured to meet the Certifier's requirements for the demo purpose during the CC Summit. The requirement was that the simulated version must work within x86.)

IMHO, it would be better to deprecated the islet-cli, and if the requirement is still valid, incorporate it into rsictl instead.

@bokdeuk-jeong
Copy link
Collaborator

@L0czek
Could you also update ${islet}/realm/linux-rsi and point it to the eac5 version?

@bitboom
Copy link
Collaborator

bitboom commented Oct 23, 2024

It would be better to deprecate islet-cli and use rsictl as is. I will also update the SDK to point the latest remote attestation and clean up the diverged code.

@L0czek
Copy link
Collaborator

L0czek commented Oct 23, 2024

@bokdeuk-jeong

Could you also update ${islet}/realm/linux-rsi and point it to the eac5 version?

#367 already does that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants