Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added examples of coverage reports #656

Merged
merged 3 commits into from
Oct 21, 2017
Merged

Added examples of coverage reports #656

merged 3 commits into from
Oct 21, 2017

Conversation

d4nyll
Copy link
Contributor

@d4nyll d4nyll commented Aug 28, 2017

No description provided.

@coveralls
Copy link

coveralls commented Aug 28, 2017

Coverage Status

Changes Unknown when pulling d0e3914 on d4nyll:patch-1 into ** on istanbuljs:master**.

README.md Outdated

```bash
nyc report --reporter=lcov
```

You can also view a [list of sample output of the different reporters](https://gist.github.com/d4nyll/6056ce74808d19899de50aaa92ab44a4).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than linking to a gist, perhaps add a page to the website: https://github.com/istanbuljs/istanbuljs.github.io

Other than that just a minor edit:

"You can find examples of the output for various reporters here"

@bcoe
Copy link
Member

bcoe commented Oct 15, 2017

@d4nyll do my comments make sense, would love to land this; I could also be convinced to land the gist, but I think placing the info on istanbul.js.org might be better.

@d4nyll
Copy link
Contributor Author

d4nyll commented Oct 16, 2017

Hey, yep it makes sense, just didn't have time to change istanbuljs.github.io. I'll do it now (or else I'll never do it)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d459677 on d4nyll:patch-1 into ** on istanbuljs:master**.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d459677 on d4nyll:patch-1 into ** on istanbuljs:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d459677 on d4nyll:patch-1 into ** on istanbuljs:master**.

@d4nyll
Copy link
Contributor Author

d4nyll commented Oct 16, 2017

Appveyor check failed, but not sure if that's related to this. I've already updated to the latest commit on master (f31d7a6) before merging.


```bash
nyc report --reporter=lcov
```

You can find examples of the output for various reporters [here](https://istanbul.js.org/docs/advanced/instrument/alternative-reporters).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link should be: https://istanbul.js.org/docs/advanced/alternative-reporters/

once this is fixed we can land things, thanks for your updates to the docs 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh silly me! I'll fix it straight away.

@bcoe
Copy link
Member

bcoe commented Oct 21, 2017

@d4nyll thank you for the contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants