-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not overwrite coverage after each test suite #42
Conversation
Pull Request Test Coverage Report for Build 133
💛 - Coveralls |
Can we get this merged? These changes would really help me with my coverage. |
I would also appreciate it if this got merged, it could possibly solve our problem |
@joe223 @Perronef5 @rafael-leal-mccormack, if I'm understanding the problem, each test suite overwrites the coverage information, so it's difficult to collect coverage for a full run? sorry that this library has seen so little love, as it turns out I just don't do a ton of front end coding 😄 I will do my best to land some of the fixes that are submitted, and would be very happy to accept more help on this library. |
@bcoe Yep, Each test suit will overwrites the coverage information, we only can get the last test suit data, I merged all test suit information in this PR to avoid data-overwriting. |
@joe223 @Perronef5 @SanterreJo this is now staged on the
Let me know if you bump into any issues. Note, I've also set up an automated release pipeline, so that we can hopefully have a faster turnaround in the future. |
Ref #20
Example https://github.com/joe223/tiny-swiper/blob/f0acd38d76a9a23a3ddcf5cabca8d5f4d37c633c/package.json#L28