Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not overwrite coverage after each test suite #42

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

joe223
Copy link
Contributor

@joe223 joe223 commented Nov 6, 2019

@coveralls
Copy link

coveralls commented Nov 6, 2019

Pull Request Test Coverage Report for Build 133

  • 34 of 34 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-5.7%) to 94.286%

Totals Coverage Status
Change from base Build 131: -5.7%
Covered Lines: 107
Relevant Lines: 115

💛 - Coveralls

@Perronef5
Copy link

Can we get this merged? These changes would really help me with my coverage.

@rafael-leal-mccormack
Copy link

I would also appreciate it if this got merged, it could possibly solve our problem

@bcoe bcoe changed the title Fix: Coverage Overwritten after each testsuite fix: do not overwrite coverage after each test suite Apr 1, 2020
@bcoe
Copy link
Member

bcoe commented Apr 1, 2020

@joe223 @Perronef5 @rafael-leal-mccormack, if I'm understanding the problem, each test suite overwrites the coverage information, so it's difficult to collect coverage for a full run?

sorry that this library has seen so little love, as it turns out I just don't do a ton of front end coding 😄 I will do my best to land some of the fixes that are submitted, and would be very happy to accept more help on this library.

@joe223
Copy link
Contributor Author

joe223 commented Apr 2, 2020

@joe223 @Perronef5 @rafael-leal-mccormack, if I'm understanding the problem, each test suite overwrites the coverage information, so it's difficult to collect coverage for a full run?

@bcoe Yep, Each test suit will overwrites the coverage information, we only can get the last test suit data, I merged all test suit information in this PR to avoid data-overwriting.

@bcoe bcoe merged commit 848aa76 into istanbuljs:master Apr 14, 2020
@bcoe
Copy link
Member

bcoe commented Apr 14, 2020

@joe223 @Perronef5 @SanterreJo this is now staged on the next tag on npm, you can try things out by running:

npm i puppeteer-to-istanbul@next.

Let me know if you bump into any issues. Note, I've also set up an automated release pipeline, so that we can hopefully have a faster turnaround in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants