Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow the output file to not include the hostname #57

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

mvegter
Copy link
Contributor

@mvegter mvegter commented May 31, 2020

No description provided.

@coveralls
Copy link

coveralls commented May 31, 2020

Pull Request Test Coverage Report for Build 161

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 99.632%

Totals Coverage Status
Change from base Build 158: -0.4%
Covered Lines: 223
Relevant Lines: 223

💛 - Coveralls

@bcoe
Copy link
Member

bcoe commented Jun 11, 2020

@mvegter bother you to resolve the conflicts 👍 this also seems like a reasonable configuration option.

Thank you for the contributions.

@mvegter mvegter force-pushed the feature/disable-hostname branch from 72a5622 to 395826e Compare June 11, 2020 07:28
@mvegter mvegter force-pushed the feature/disable-hostname branch from 395826e to 91a8c33 Compare June 11, 2020 07:38
@mvegter
Copy link
Contributor Author

mvegter commented Jun 11, 2020

Hi @bcoe, should be fixed. These changes (but a bit more dirty in a fork 😉) were required for some projects, this way more users can use it.

@bcoe bcoe merged commit 3a5b312 into istanbuljs:master Jun 11, 2020
@bcoe
Copy link
Member

bcoe commented Jun 11, 2020

@mvegter appreciate the contributions 👍

Unfortunately, I haven't done a ton of frontend coding in recent years, so am not a consumer of this library ... I really appreciate the community help.

@bcoe
Copy link
Member

bcoe commented Jun 11, 2020

@mvegter try out 1.4.0 with your changes.

@mvegter mvegter deleted the feature/disable-hostname branch June 11, 2020 20:00
@mvegter
Copy link
Contributor Author

mvegter commented Jun 11, 2020

@bcoe It works as expected, no changes in our coverage detected 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants