Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding meshConfig for waypoint class names #3006

Closed
wants to merge 1 commit into from
Closed

adding meshConfig for waypoint class names #3006

wants to merge 1 commit into from

Conversation

ilrudie
Copy link
Contributor

@ilrudie ilrudie commented Nov 27, 2023

adds a field to configure gateway class names which are being used as ambient waypoint proxies

resolve #3005

@ilrudie
adding meshConfig for waypoint class names
7ee6b1d 
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
@ilrudie ilrudie requested a review from a team as a code owner November 27, 2023 23:05
@istio-policy-bot
Copy link

😊 Welcome @ilrudie! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2023
@istio-testing
Copy link
Collaborator

@ilrudie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
release-notes_api 7ee6b1d link false /test release-notes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie ilrudie added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Nov 27, 2023
howardjohn
howardjohn requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold for discussion in #3005 (comment)

@ilrudie
Copy link
Contributor Author

ilrudie commented Dec 11, 2023

Should we just go ahead and close this? It likely isn't necessary on the current track as John has mentioned.

@keithmattix, you had commented on this in Louis's doc a little. WDYT now that we've all had some time for thinking about John's proposal more?

@ilrudie
Copy link
Contributor Author

ilrudie commented Dec 14, 2023

Going to close this just to clean up since it doesn't look like there's much support or need for it at the moment. We can circle back if need arises.

@ilrudie ilrudie closed this Dec 14, 2023
@linsun linsun mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn requested changes

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Waypoint Extensions
4 participants
@ilrudie @istio-policy-bot @istio-testing @howardjohn