You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
The sidecar initializer is configured through command line flags. It might be nice to pull the configuration and sidecar template from a k8s ConfigMap (e.g. envoy-initializer.yaml).
NOTE: The sidecar initializer and kube-inject currently share the same injection programmatic template. Adoption of envoy-initializer.yaml style template should ensure these templates don't diverge. kube-inject could use the newer k8s ConfigMap but care should be taken to avoid breaking offline mode, e.g. kube-inject might need to take ConfigMap YAML as argument to retrieve template.
The text was updated successfully, but these errors were encountered:
I think that the injected configuration should be handled by pilot but not the configMap as the end user may update the configMap and caused the initializer does not work. @ayj
I'm not sure how pushing injection configuration into Pilot would solve that problem. The end user could make the same misconfiguration errors there. Ultimately the injection configuration should be protected and I believe that is possible today with appropriate RBAC settings on the ConfigMap.
The sidecar initializer is configured through command line flags. It might be nice to pull the configuration and sidecar template from a k8s ConfigMap (e.g. envoy-initializer.yaml).
NOTE: The sidecar initializer and kube-inject currently share the same injection programmatic template. Adoption of envoy-initializer.yaml style template should ensure these templates don't diverge. kube-inject could use the newer k8s ConfigMap but care should be taken to avoid breaking offline mode, e.g. kube-inject might need to take ConfigMap YAML as argument to retrieve template.
The text was updated successfully, but these errors were encountered: