You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improve Maintainability in GreenCityUser Service and Service-API Modules
Changes Required:
ApiLocate.java: Remove the @parameters section for clarity and conciseness.
CustomExceptionHandlerTest.java: Eliminate unnecessary commented-out test cases and correct the value assignments for improved test clarity.
ManagementSecurityControllerTest.java: Remove redundant local variable assignments for dto.
JwtTool.java: Replace RuntimeException with a more specific IllegalArgumentException to enhance exception handling and add requirement handler exception.
Annotations: Add @SuppressWarnings("java:S1118") to EmailAddressValidator, LanguageValidationUtils, and UrlValidator to bypass SonarLint issues.
Mocking Updates: Replace the deprecated initMocks with @ExtendWith(MockitoExtension.class) in SearchCriteriaTest.java, CustomSpecificationTest.java, and UserSpecificationTest.java.
Code Refactor (OwnSecurityServiceImplTest.java): Rename the field notVerifiedUser and refactor lambdas to ensure only one exception-throwing invocation per lambda.
VerifyEmailServiceImplTest.java: Remove commented-out code blocks that are no longer needed.
UserServiceImplTest.java: Rename the ambiguous user variable, and remove redundant assignments to sixFriendsWithOnlineStatusDtos and friendsWithOnlineStatusDtos.
The text was updated successfully, but these errors were encountered:
K4sik
changed the title
[GreenCityUser, Sonar] Fix Issues in GreenCityUser Services modules
[GreenCityUser, Sonar] Fix Issues in GreenCityUser service and service-api modules modules
Sep 30, 2024
K4sik
changed the title
[GreenCityUser, Sonar] Fix Issues in GreenCityUser service and service-api modules modules
[GreenCityUser, Sonar] Fix Issues in GreenCityUser service and service-api modules
Sep 30, 2024
Improve Maintainability in GreenCityUser Service and Service-API Modules
Changes Required:
The text was updated successfully, but these errors were encountered: