Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin/ArtGallery] Both new and previous art are saved after template is edited #1282

Open
Shossy opened this issue Jun 3, 2024 · 0 comments

Comments

@Shossy
Copy link
Contributor

Shossy commented Jun 3, 2024

Environment: macOS 13.6.1/Google Chrome 125.0.6422.77
Reproducible: always

Description:
When editing a template and saving changes, both the newly added art and the previous art are saved, instead of only the updated selection. Additionally, an error occurs when attempting to edit the template again.

Preconditions:

  • The user is logged in as an admin on the "Новий стріткод" page.
  • The "Арт-галерея" section is navigated to.
  • A couple of images have been added to the "Арт-галерея".

Steps to reproduce:

  1. Click the "Обрати шаблон" button and choose a template
  2. Add images from the "Арт-галерея" to the chosen template
  3. Save the template by clicking the "Додати" button
  4. Click the Cogwheel icon next to the newly created template and select "Редагувати"
  5. Replace at least one image in the template with another from the "Арт-галерея"
  6. Save the edited template by clicking the "Додати" button
  7. Check the main template view to verify the saved changes

Expected result:
When the user edits the template and clicks the ‘Додати’ button, the new art is saved without error.

Actual result:
When the user edits the template and clicks the ‘Додати’ button, both the new and previous art are saved.
When the user clicks on the "Редагувати" button, an error occurs.

User story: #127
Test case: https://github.com/orgs/ita-social-projects/projects/21/views/1?pane=issue&itemId=66890486

@Shossy Shossy added this to StreetCode Jun 3, 2024
@Shossy Shossy converted this from a draft issue Jun 3, 2024
@NastiaVeret NastiaVeret moved this from ✍Planned to 🏗 In progress in StreetCode Jun 5, 2024
@NastiaVeret NastiaVeret moved this from 🏗 In progress to 👀PR in StreetCode Jun 6, 2024
@NastiaVeret NastiaVeret moved this from 👀PR to 🔎In Q/A in StreetCode Jun 8, 2024
@arisssha arisssha self-assigned this Jun 10, 2024
@arisssha arisssha changed the title [Admin/ArtGallery] ArtGallery editting templates [Admin/ArtGallery] Both new and previous art are saved after template is edited Jun 11, 2024
@arisssha arisssha moved this from 🔎In Q/A to 💚Ready to release in StreetCode Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💚Ready to release
Development

No branches or pull requests

4 participants