Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pictures for carousel functional #711

Merged
merged 20 commits into from
Feb 4, 2022
Merged

Pictures for carousel functional #711

merged 20 commits into from
Feb 4, 2022

Conversation

besizzo
Copy link
Collaborator

@besizzo besizzo commented Feb 2, 2022

Pull Request Template

Type of Pull Request

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. For example, tooling, build system, CI, docs, etc.)

Related links

Issue link
???

Story link
#485

Description

Functional for adding pics for mobile devices implemented. Carousel images now grouped in accordion.

besizzo added 20 commits January 21, 2022 20:59
@besizzo
fields now are one third of the container width
95cf492
@besizzo
separate state for mobile pic created
438e982
@besizzo
UI finished
3e16320
@besizzo
added importantMobileImg to the store post object; posts without mobi…
6b47efb 
…le picture uploaded cannot be added to the carousel now
@besizzo
some css and notes added, still cannot update pics to imgur, constant…
633d8e0 
…ly getting 429 error
@besizzo
modified actions and reducer for mobile pic update
07d685a
@besizzo
refactoring just started
ec1bbf7
@besizzo
some refactoring is done, areas for uploading desktop and mobile pics…
23bdf3f 
… are now on both new post page and edit post pages
@besizzo
should work fine, waiting for backend team to modify post object
b8bf599
@besizzo
refactoring is going on, comment added
90e66be
@besizzo
some minor changes
c8d71a5
@besizzo
some minor changes
c825f7f
@besizzo
first accordion inserted
e781ac3
@besizzo
both accordion on their places, waiting for post object to be reworke…
b55b5cf 
…d. Final cleanup is necessary
@besizzo
a couple of files renamed
110cffb
@besizzo
locales file conflict resolved
96fcdd4
@besizzo
two braches merged, some renaming performed
0e75fb9
@besizzo
few minor changes, some refactoring
5c688c8
@besizzo
DOPYS state adjusted
9a0f6ce
@besizzo
minor changes before PL
2538d61
@sarhan-azizov sarhan-azizov merged commit 7e0edc6 into develop Feb 4, 2022
@sarhan-azizov sarhan-azizov deleted the carousel_accordion_feature branch February 4, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarhan-azizov sarhan-azizov Awaiting requested review from sarhan-azizov sarhan-azizov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@besizzo @sarhan-azizov