Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Karma and related packages devDependencies #311

Open
BennyLi opened this issue Jan 8, 2020 · 0 comments
Open

Make Karma and related packages devDependencies #311

BennyLi opened this issue Jan 8, 2020 · 0 comments
Labels
prio:low type:task Small enhancements

Comments

@BennyLi
Copy link
Contributor

BennyLi commented Jan 8, 2020

In our package.json karma is defined as dependency. If you run npm audit on a branch with the latest node and npm LTS version, then some security issues are listed, for which all karma is responsible. It would be nice if we define karma as a devDependency, because we don't need it for the production build, and then we don't ship a production-dependency with a security issue, even though it's probably not bad.

@BennyLi BennyLi added type:task Small enhancements prio:low labels Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio:low type:task Small enhancements
Projects
None yet
Development

No branches or pull requests

1 participant