Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realfavicongenerator integration #14

Closed
paulirish opened this issue Oct 23, 2014 · 5 comments
Closed

realfavicongenerator integration #14

paulirish opened this issue Oct 23, 2014 · 5 comments

Comments

@paulirish
Copy link

from google/web-starter-kit#442 (comment) ...

I've been talking with the creator of the aforementioned realfavicongenerator.net and we might be doing some work together that will make Favicons and RFG more awesome (using his comprehensive API).

What's the status on that? I think it'd be great to combine efforts here.

cc @phbernard

@haydenbleasel
Copy link
Contributor

Hahaha @phbernard I just realised I could tag you in these issues! I'll CC you in the other one so you can read up :) @paulirish Work's being started on the real-favicon branch - nothing major so far as we need to build some Node modules for RFG first.

@paulirish
Copy link
Author

Killer. sounds good man!

@haydenbleasel
Copy link
Contributor

@paulirish Some stuff from our Gitter chat on RFG. Things to implement on the API:

  • android homescreen
  • apple touch icons
  • coast
  • favicons (png and ico)
  • firefox icons
  • windows MS tiles
  • browserconfig.xml
  • manifest.webapp
  • opengraph
  • yandex browser

Other stuff for RFG:

  • If a user already has a pre-configured (browserconfig.xml | manifest.webapp | android_chrome_manifest.json), we don't want to overwrite it (just append to it)
  • Support multiple source inputs on the API (see Favicons for logic)
  • Current HTML manipulation is really sketchy, it adds a bunch of blank lines. I fixed this in Favicons so I'll PR it
  • we need to split out rfg_api.js as a module so you can use it across grunt / node packages
  • publish real-favicons node implementation to npm

Stuff for Favicons:

  • Apple Startup Images
  • Snazzy rewrite

Once this is all done, I can delete most of the functions on Favicons so it runs off the RFG API, make it more of an intelligence wrapper with extra stuff. Guhhh so much stuff to do.

@haydenbleasel
Copy link
Contributor

@phbernard @paulirish Guess what?! It's done :)

@paulirish
Copy link
Author

Whoaaaa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants