Autoload with PSR-4 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👎 for moving any files. It's not needed. |
|
@GrahamCampbell I've updated the PR to not moving any files. |
| /* phpunit tests/HashidsTest.php */ | ||
| namespace Hashids\Tests; | ||
|
|
||
| use Hashids\Hashids; | ||
|
|
||
| class HashidsTest extends \PHPUnit_Framework_TestCase { |
There was a problem hiding this comment.
would be better to import this imo instead of having a leading slash
Since the PSR-0 is deprecated we should use to PSR-4 instead.
|
Guys, I haven't forgotten about this. Bear with me, as I'm catching up with my backlog. |
|
No worries :) This PR will add PSR-4 and drop PSR-0 without breaking anything. |
|
Thanks for cleaning up the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the PSR-0 is deprecated we should use to PSR-4 instead.