Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings compilation error on Windows due to usage of near & far #689

Open
fodinabor opened this issue May 9, 2016 · 0 comments
Open

Bindings compilation error on Windows due to usage of near & far #689

fodinabor opened this issue May 9, 2016 · 0 comments

Comments

@fodinabor
Copy link
Contributor

On Windows near and far are macros and cannot be used as variable names.

Number Ray::boxIntersect(const Vector3 &box, const Matrix4 &transformMatrix, float near, float far) const uses these variable names and it works as they are parameters. But in the wrapper headerfiles for the scripting languages this does not work!

https://github.com/ivansafrin/Polycode/blob/goodbye_cmake/include/polycode/bindings/javascript/PolycodeJSWrappers.h#L4459
https://github.com/ivansafrin/Polycode/blob/goodbye_cmake/include/polycode/bindings/lua/PolycodeLuaWrappers.h#L10806

Possible fix: rename the parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant