-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gRPC logging stream server #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
applejag
force-pushed
the
feature/grpc-server
branch
2 times, most recently
from
February 21, 2022 15:17
3b292a9
to
369c022
Compare
applejag
force-pushed
the
feature/grpc-server
branch
from
February 24, 2022 15:10
369c022
to
5c18011
Compare
applejag
requested review from
Alexamakans,
fredx30,
Nisserino and
ZKemstedt
February 24, 2022 15:10
Alexamakans
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 👍🏻
Nice to see how simple the multiplexing usage is o:
Alexamakans
approved these changes
Feb 25, 2022
applejag
commented
Feb 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
file, according to docs:https://iver-wharf.github.io/#/development/changelogs/writing-changelogs
Summary
api/wharfapi/v1/builds.proto
Makefile
soheilhy/cmux
grpc.go
http.go
Motivation
The SQL code is what mostly stands out in this PR IMO. What I wanted to do was:
In Sqlite this was simple, as you basically do
INSERT OR IGNORE INTO
instead of justINSERT INTO
, while Postgres does not have such a feature, but I found a solution that instead made use of aJOIN
statement inside theINSERT
.Please look at the test files for the best overview of what the SQL actually looks like.
The Sqlite function isn't really working as we do not have foreign key constraints enabled. However, this is planned in #145.
Protobuf versioning
I've added the major version to both the path in
api/wharfapi/v5/builds.proto
as well as the Protobuf package namewharf.api.v5
.My reasoning here is that it should be the same as the wharf-api version, for simplicity sake. But to be able to keep backwards compatiblity, when jumping to v6 the wharf-api needs to keep supporting v5. In other words, when bumping to v6, we will have the files:
api/wharfapi/v5/*.proto
api/wharfapi/v6/*.proto
For v7, we will have the files:
api/wharfapi/v6/*.proto
api/wharfapi/v7/*.proto
Up for discussion: Should the gRPC protobuf API have a separate versioning? It could, but I think that'd be adding excess confusion.
It does however make it so if we have a breaking change in the HTTP REST API then we also have to bump the gRPC API. Perhaps that's a good thing, but I'm not sure. Input on this is well appreciated.
Closes #130