Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration): improved avoidance of Test Explorer window from xcodebuild.nvim plugin #213

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

wojciech-kulik
Copy link
Contributor

@wojciech-kulik wojciech-kulik commented Feb 10, 2024

I discovered one problem with xcodebuild.nvim integration - when there is a window below (like Trouble or nvim-dap, or anything else), then Fidget is still offset even though there is no collision with xcodebuild.nvim plugin.

I fixed that by checking if there is any other window below Test Explorer.

After fix:

fix2.mov

@wojciech-kulik
Copy link
Contributor Author

wojciech-kulik commented Feb 11, 2024

Btw. I realized that in general, all integrations will be about avoidance of specific areas, but the problem is that every integration is going to handle offsets manually which may cause conflicts between integrations.

Maybe it would be worth considering in the future a different interface where each plugin can return the area to avoid and then Fidget merges all of them and sets x and y offset :).

@wojciech-kulik
Copy link
Contributor Author

@j-hui could you take a look here?

@j-hui
Copy link
Owner

j-hui commented Feb 14, 2024

Sorry about the delay.

Btw. I realized that in general, all integrations will be about avoidance of specific areas, but the problem is that every integration is going to handle offsets manually which may cause conflicts between integrations.

Maybe it would be worth considering in the future a different interface where each plugin can return the area to avoid and then Fidget merges all of them and sets x and y offset :).

Yeah, that's a good point, and I like that suggestion.

Also, it occurs to me that when looking at windows that lie below the Fidget window, we can much more easily exclude by filetype, which many plugins set. That will allow the user to simply specify a blacklist of filetypes to avoid.

@wojciech-kulik
Copy link
Contributor Author

@j-hui blacklisting specific filetypes sounds great, would be very flexible 🔥

@j-hui j-hui merged commit 7d1873a into j-hui:main Feb 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants