Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.20 binary is not signed #67

Closed
TheSaltyKorean opened this issue Jun 22, 2019 · 10 comments
Closed

v3.0.20 binary is not signed #67

TheSaltyKorean opened this issue Jun 22, 2019 · 10 comments
Labels

Comments

@TheSaltyKorean
Copy link

'warning BC41997: Referenced assembly 'CommandLineArgumentsParser, Version=3.0.20.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.'

Not sure what happened but the binary isn't signed again

@TheSaltyKorean
Copy link
Author

Looks like the last version that was signed was version 3.0.16

@StefH
Copy link
Collaborator

StefH commented Jun 23, 2019

@j-maly It seems the pfx file is password protected, so cannot create a new build. Do you have the password? If so, can you share? Or just create version 3.0.21?

@StefH StefH added the bug label Jun 23, 2019
@TheSaltyKorean
Copy link
Author

bump ...
We should be able to create a new signing file. An snk file will do just fine. The public nature of the file/password is rather meaningless as even Microsoft hopes to do away with signing files. The problem comes in when software publishers like me need signed files in order for applications to work on corporate desktops due to policy restrictions

@StefH
Copy link
Collaborator

StefH commented Jul 8, 2019

I can just add a snk file to git and just create a signed dll.

Not 100% secure/preferred but this will work.

@alexandre-lecoq
Copy link
Contributor

If you can add a snk file that would be great.
Lot of projects do that : https://github.com/commandlineparser/commandline/blob/master/CommandLine.snk

@askids
Copy link

askids commented Aug 12, 2020

Any plans of addressing this in near term?

@StefH
Copy link
Collaborator

StefH commented Aug 13, 2020

Hello @j-maly , is it ok that I create a new signed NuGet with a new snk file?

@askids
Copy link

askids commented Dec 1, 2020

@StefH any plans to publish the new version using new snk file?

@StefH
Copy link
Collaborator

StefH commented Dec 1, 2020

Hello @askids, a new version will be added to NuGet shortly.

#72

@StefH StefH closed this as completed Dec 1, 2020
@askids
Copy link

askids commented Dec 21, 2020

Thank you @StefH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants